feat(api): retrieve stored temporal-context requests by extra-segment GET - #463
Conversation
… GET
GAP-003A unique slice: GET /v1/temporal-context/{idempotency_key}/request returns the accepted LineageWeave create request on AnalysisRunLiveService / tepp-loopback. Metric-free of RMSE/tepp.scientific_acceptance.v1. inference_status remains temporal_association_only. Naruon refused. NaruonLiveService stays POST-only. ADR 0091.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| self.accepted_temporal_contexts | ||
| .insert(replay_key, (context_request.clone(), item)); |
There was a problem hiding this comment.
🟡 Failed POSTs leave retrievable requests
When the generated response exceeds 64 KiB, insert stores the request before serialization returns an error. Both GET endpoints then expose a failed POST.
Prompt for agents
In crates/tepp_api/src/analysis_run_live.rs, accept_temporal_context mutates accepted_temporal_contexts before build_temporal_context and TemporalContextResponse::to_json complete. A temporal-context request can fit its 64 KiB input limit while the expanded response exceeds the same output limit, causing POST to return LimitExceeded after the registry has already changed. Reorder the operation so all response construction and serialization succeeds before inserting a new idempotency entry, while preserving exact replay and conflict behavior.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Folded into #464
Closed as
superseded_by_fold, not discarded. #464's head contains this PR as its direct ancestor and has been retargeted to this PR's former base, so the stored-request GET code/tests and this PR's review history remain intact while queue WIP is reduced.Canonical landing vehicle: #464 (
feat(api): consolidate temporal-context stored-request GET and CLI).Do not reopen unless the folded head demonstrably loses unique behavior or evidence.